From 91204bb2cae74913085edc57c52be478870a3944 Mon Sep 17 00:00:00 2001
From: "c.wendisch" <c.wendisch@gsi.de>
Date: Wed, 11 Jan 2023 12:26:11 +0100
Subject: [PATCH] fix voltage change suggestions

---
 scripts/check_voltages.pl | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/scripts/check_voltages.pl b/scripts/check_voltages.pl
index fe070b0..927fccf 100755
--- a/scripts/check_voltages.pl
+++ b/scripts/check_voltages.pl
@@ -16,32 +16,30 @@ trb_init_ports() or die trb_strerror();
 my $values = trb_register_read_mem(0xfe90,0xd488,0,4);
 
 my $stepsize = 200;
-my $headroom = 200;
+my $headroom = 250;
 my @nominal = (1100,3300);
 print("Suggested changes to voltage settings:\n");
 print("Board\tActual\tChannel\tChange\n"); 
 foreach my $b (sort keys %{$values}) {
   my $value = $values->{$b}[0] / 16;
-  my $diff = $value - $nominal[0];
-  if($diff > $headroom+$stepsize) {
+  my $diff = $value - $nominal[0] - $headroom;
+  if($diff > $stepsize) {
     my $sugg = $diff/$stepsize ;
     printf("%04x\t%i\t%i\t%i\n",$b,$value,1,-$sugg);
     }
-  if($diff < $headroom) {
-    my $sugg = ($diff+$headroom)/$stepsize;
+  if($diff < 0) {
+    my $sugg = (-$diff)/$stepsize + 1;
     printf("%04x\t%i\t%i\t%i\n",$b,$value,1,$sugg);
     }
-}
 
-foreach my $b (sort keys %{$values}) {
-  my $value = $values->{$b}[2] / 16;
-  my $diff = $value - $nominal[1];
-  if($diff > $headroom+$stepsize) {
+  $value = $values->{$b}[2] / 16;
+  $diff = $value - $nominal[1] - $headroom;
+  if($diff > $stepsize) {
     my $sugg = $diff/$stepsize ;
     printf("%04x\t%i\t%i\t%i\n",$b,$value,0,-$sugg);
     }
-  if($diff < $headroom) {
-    my $sugg = ($diff+$headroom)/$stepsize;
+  if($diff < 0) {
+    my $sugg = (-$diff)/$stepsize + 1;
     printf("%04x\t%i\t%i\t%i\n",$b,$value,0,$sugg);
     }
 }
-- 
2.43.0